Skip to content

test(tmachine): add Debian installer profile - #3461

Merged
elezar merged 5 commits into
mainfrom
feat/add-debian-installer-profile
Sep 21, 2026
Merged

test(tmachine): add Debian installer profile#3461
elezar merged 5 commits into
mainfrom
feat/add-debian-installer-profile

Conversation

@SDAChess

@SDAChess SDAChess commented Sep 18, 2026 •
edited by elezar
Loading

Copy link
Copy Markdown
Collaborator

Summary

Add a tmachine installer profile that installs the Ubuntu Debian package instead of copying loose CLI and gateway binaries. Release Dev and Release Tag inherit an additional Ubuntu conformance lane from the shared default matrix, while Branch E2E and manual integration remain explicitly binary-only.

Related Issue

Part 1 of #3454

Changes

  • Add an Ansible playbook and tmachine deb installer profile for artifacts/packages/openshell.deb.
  • Resolve installed OpenShell executables across /usr/local/bin and /usr/bin layouts.
  • Keep qualification-only runtime image configuration separate from the operator-owned gateway configuration and select it through the packaged service's gateway.env hook.
  • Optionally stage the amd64 Debian artifact in shared integration inputs.
  • Add Ubuntu Debian-package conformance to the shared default matrix, with Branch E2E and manual integration retaining explicit binary-only matrices.
  • Document the installer input and release coverage.

Testing

  • mise run pre-commit
  • Unit tests added/updated (not applicable; configuration and workflow coverage)
  • E2E tests added/updated
  • nix build --no-link --print-out-paths .#tmachine-config
  • nix develop .#testing -c cargo test --manifest-path tests/tmachine/Cargo.toml
  • Ansible syntax checks for all touched playbooks
  • Focused Actionlint passes for all modified workflows
  • Focused Zizmor reviewed; findings are existing floating ci:latest image references
  • tasks/scripts/test-packaging-assets.sh
  • nix run .#tmachine -- test ubuntu-docker-rootful deb conformance using the matching published Debian package and runtime images

Full-repository Actionlint also reports existing concurrency.queue schema findings in unrelated documentation workflows.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot

copy-pr-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown

🌿 Preview your docs: https://nvidia-preview-pr-3461.docs.buildwithfern.com/openshell

@SDAChess

SDAChess commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

Part 1 of #3454

elezar
elezar reviewed Sep 18, 2026
View reviewed changes
Comment thread .github/workflows/release-dev.yml
elezar
elezar reviewed Sep 18, 2026
View reviewed changes
Comment thread tests/ansible/playbooks/conformance/cli.yaml
elezar
elezar reviewed Sep 18, 2026
View reviewed changes
Comment thread .github/workflows/integration-runner.yml
elezar
elezar reviewed Sep 18, 2026
View reviewed changes
Comment thread tests/ansible/roles/openshell_gateway/tasks/main.yaml
@SDAChess SDAChess mentioned this pull request Sep 18, 2026
Open
9 tasks
SDAChess
SDAChess commented Sep 18, 2026
View reviewed changes
Comment thread tests/ansible/playbooks/openshell-deb.yaml
@SDAChess @elezar
test(tmachine): add Debian installer profile
353eeeb 
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@SDAChess @elezar
refactor(ci): centralize conformance matrix
b15a3ec 
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@SDAChess @elezar
test(ci): prefer packaged conformance artifacts
0370af6 
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@SDAChess @elezar
test(tmachine): use packaged Debian gateway service
691ea14 
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@elezar elezar mentioned this pull request Sep 21, 2026
Open
10 tasks
@elezar
test(tmachine): isolate Debian qualification config
d70dba9 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the feat/add-debian-installer-profile branch from b37aab1 to d70dba9 Compare September 21, 2026 09:32
@elezar elezar added the test:e2e Requires end-to-end coverage label Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

Label test:e2e applied for d70dba9. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@elezar

elezar commented Sep 21, 2026

Copy link
Copy Markdown
Member

Bypassing docker test failure due to #3501

@elezar
elezar merged commit 65eb916 into main Sep 21, 2026
117 of 120 checks passed
@elezar
elezar deleted the feat/add-debian-installer-profile branch September 21, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elezar elezar elezar approved these changes
@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner
@sjenning sjenning Awaiting requested review from sjenning sjenning is a code owner
@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr derekwaynecarr is a code owner

Assignees

No one assigned

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SDAChess @elezar